Skip to content

[PWGLF] Fix includes - #17793

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-PWGLF
Sep 11, 2026
Merged

[PWGLF] Fix includes#17793
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu-PWGLF

Conversation

@vkucera

@vkucera vkucera commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 146 errors, ⚠️ 279 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix includes [PWGLF] Fix includes Sep 5, 2026
@vkucera
vkucera marked this pull request as ready for review September 6, 2026 14:30
@alibuild

alibuild commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 319d796 at 2026-09-09 09:56:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 319d796 at 2026-09-09 18:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 644 warnings.'
Found 6 errors and 644 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/191d262c85aa1189d4740bf689db9226c303fbcf/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/lambdaJetPolarizationIons.cxx:664:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/lambdaJetPolarizationIons.cxx:675:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/lambdaJetPolarizationIons.cxx:686:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGLF/TableProducer/Strangeness/lambdaJetPolarizationIons.cxx:710:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGLF/Tasks/Strangeness/lambdapolsp.cxx:1718:13: error: Value stored to 'tagb' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/Tasks/Strangeness/lambdapolsp.cxx:2087:11: error: Value stored to 'tagb' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 644 -gt 0 ]]
++ cat /sw/BUILD/191d262c85aa1189d4740bf689db9226c303fbcf/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:97:22: warning: variable 'hEvtMC' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:98:22: warning: variable 'hImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:99:22: warning: variable 'hImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:100:22: warning: variable 'hRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:101:22: warning: variable 'hImpactParamGenOneReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:102:22: warning: variable 'hGenOneRecoCentrality' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:103:22: warning: variable 'hGenEventsNchEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:104:22: warning: variable 'hGenEventsNchEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:105:22: warning: variable 'hRecoCentralityColvsMultiplicityRecoEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:106:22: warning: variable 'hRecoCentralityColvsMultiplicityRecoEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:107:22: warning: variable 'hRecoCentralityColvsMultiplicityFT0C' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:108:22: warning: variable 'hRecoCentralityColvsImpactParamReco' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:109:22: warning: variable 'hGenCentralityColvsMultiplicityGenEta05' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:110:22: warning: variable 'hGenCentralityColvsMultiplicityGenEta08' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:111:22: warning: variable 'hGenCentralityColvsMultiplicityFT0C' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:112:22: warning: variable 'hGenCentralityColvsImpactParamGen' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:113:22: warning: variable 'hGenLi4BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:114:22: warning: variable 'hGenLi4vsImpactParameterBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:115:22: warning: variable 'hGenLi4vsMultiplicityGenEta05BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:116:22: warning: variable 'hGenLi4vsMultiplicityGenEta08BeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:117:22: warning: variable 'hGenLi4vsMultiplicityFT0CBeforeEvtSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:118:22: warning: variable 'hGenLi4AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:119:22: warning: variable 'hGenLi4vsImpactParameterAfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:120:22: warning: variable 'hGenLi4vsMultiplicityGenEta05AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:121:22: warning: variable 'hGenLi4vsMultiplicityGenEta08AfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:122:22: warning: variable 'hGenLi4vsMultiplicityFT0CAfterSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:305:8: warning: constructor does not initialize these fields: mCcdb [cppcoreguidelines-pro-type-member-init]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:342:85: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:680:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:732:14: warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:784:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1622:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1624:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/he3HadronFemto.cxx:1644:57: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator Author

Ping

@vkucera

vkucera commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Ping 2

@vkucera

vkucera commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@omvazque @skundu692 @mpuccio @mario-krueger @maciacco @HorstMa @dmallick2 @smaff92 @prottayCMT
It's been six days.

@vkucera
vkucera merged commit e1848be into AliceO2Group:master Sep 11, 2026
11 of 14 checks passed
@vkucera
vkucera deleted the iwyu-PWGLF branch September 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainschotter romainschotter romainschotter approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@mario-krueger mario-krueger Awaiting requested review from mario-krueger mario-krueger is a code owner
@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner
@HorstMa HorstMa Awaiting requested review from HorstMa HorstMa is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkucera @alibuild @romainschotter